Slitherine

quote:

ORIGINAL: Chliperic

Are you realizing we are currently building a better way to create data in AGE game than in the official way?

...

I just can't wait to apply this for SVF 2.0; Development time divided by 4 to 5 at least.

quote:

ORIGINAL: Chliperic

Another false positive

WARNING: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Events/BalticSetup.sct, at (or before) line 224: suspicious, undocumented usage of ; as field separator

in event evt_nam_WHI_Baltarmydeploymentconditionfulfilled:

221
222 SelectRegion = $Liepaja
223
224> ChangeAssetsProd = 10;5;0;0;0;0
225
226 SelectFaction = $WHI
227 SelectRegion = $Valga

Syntax: ChangeAssetsProd = Supply|Ammo|Power|Money|WSU|Conscripts

; may be used in events as stated in the wiki

quote:

(NB: it works also like this : 0;0;0;0;10;0 in an event file)

changeassetsprod: _CHANGEASSETSPROD eq int sc int sc int sc int sc int sc int {
                    txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, undocumented usage of ; as field separator");
                  }
                | _CHANGEASSETSPROD eq int vb int vb int vb int vb int vb int
                {
                /*                                                              
                http://www.ageod.net/agewiki/ChangeAssetsProd                   
                Syntax:  ChangeAssetsProd = Supply|Ammo|Power|Money|WSU|Conscripts
                */
                }
                ;

changeassetsprod: _CHANGEASSETSPROD eq int sc int sc int sc int sc int sc int {
                  if (filetype != FILETYPE_EVENTS)
                      txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, undocumented usage of ; as field separator");
                  }
                | _CHANGEASSETSPROD eq int vb int vb int vb int vb int vb int
                {
                /*
                http://www.ageod.net/agewiki/ChangeAssetsProd
                Syntax:  ChangeAssetsProd = Supply|Ammo|Power|Money|WSU|Conscripts
                (NB: in an event file, it works also like this: 0;0;0;0;10;0)
                */
                }
                ;

[root@telemann agewiki]# pwd
/home/berto/games/ageod/agewiki/www.ageod.net/agewiki

[root@telemann agewiki]# egrep -i "works also like this" * | awk -F= '{print $2}' | awk -F\& '{print $1}' | sort | uniq

ChangeAssetsProd

[root@telemann agewiki]# egrep -i "is also a valid syntax" * | awk -F= '{print $2}' | awk -F\& '{print $1}' | sort | uniq

AI.SetPoolRatio
AlterCuSubUnit
ChangeVPCount

quote:

ORIGINAL: berto



But why didn't I get this kind of cooperation and feedback months before? ...

quote:

ORIGINAL: Chliperic

ANother false positive

in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Events/RUS F4 Options Politics.sct, at (or before) line 1770: syntax error: #-# (0x2d), #-999#

in event evt_nam_DonCossack_infighting:

1767 Actions
1768 ChgFacEngagementPts = -9
1769
1770> SetEvtOccurs = evt_nam_DonCossack_infighting;MaxOccurs;-999
1771 SetEvtOccurs = evt_nam_DonCossack_infighting;CuOccurs;0
1772 GenTextMsg = opt_notify_WHI_setting_strategy;1;NULL;NULL;NULL
1773

Syntax: SetEvtOccurs = EventName; OccParam; Value


-999 is a correct value to avoid an event to fire

setevtoccurs:   _SETEVTOCCURS eq evtnam sc occurs sc intpos
                {
                /*
                http://www.ageod.net/agewiki/SetEvtOccurs
                Syntax:  SetEvtOccurs = EventName; OccParam; Value
                */
                }
                ;

setevtoccurs:   _SETEVTOCCURS eq evtnam sc occurs sc int
                {
                /*
                http://www.ageod.net/agewiki/SetEvtOccurs
                Syntax:  SetEvtOccurs = EventName; OccParam; Value
                */
                }
                ;

[root@telemann agelint]# ./kwddat SetEvtOccurs | egrep -cv 999
1044
[root@telemann agelint]# ./kwddat SetEvtOccurs | egrep -c 999
11

quote:


EventName

String; Name (alias) of the event

OccParam

String; [MaxOccurs, CuOccurs];

* MaxOccurs - Changes the allowed amount of occurences.

MaxOccurs=0: Event never fires.

MaxOccurs=999: Event fires infinite times.

* CuOccurs - Changes the counter for how often the event already has occured.

Value

Integer; [0, 999]

quote:

ORIGINAL: Chliperic

Not sure if this one is a false positive

ERROR: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/GameData/RgnDecisions/6-Nep.rgd, at (or before) line 16: syntax error: #I# (0x49), #Inp_Abs_EngagementPts#

13 Duration = 4
14 Inp_Rel_Morale = 1
15 Inp_Abs_Money = 13
16> Inp_Abs_EngagementPts = 3
17 RelBaseFlatValue = 100
18 RelBaseOwnAreaCityLevel = 1
19 SpecialOutputGain_Loyalty = 36

Regional decisions excel file has a column named by this expression,so I wonder why it is marked as wrong.

quote:

ORIGINAL: Chliperic

Let do it easy: I'm writing an event I will test soon. So we'll know if -999 work or not

quote:

ORIGINAL: Chliperic

For the rest, I've almost achieved my search of false positives...Not that much, in conclusion :-) And so much almost invisible bugs solved in so few time...

quote:

ORIGINAL: berto

quote:

ORIGINAL: Chliperic

Let do it easy: I'm writing an event I will test soon. So we'll know if -999 work or not

That was part of my original plan: When still in doubt between the kwd usage and the AGEWiki docs, I had planned to decide issues with real-game experimentation. But my initial attempts were undercut by the clumsy, cumbersome, time-draining "official" procedure: .xls DB -> .csv saved file -> CSV Splitter -> run in game -> inspect log files. Life is too short for that!

But, yes, no speculating about the number of teeth a horse has, rather "Look in the Horse's Mouth"!

quote:

ORIGINAL: berto

quote:

ORIGINAL: Chliperic

For the rest, I've almost achieved my search of false positives...Not that much, in conclusion :-) And so much almost invisible bugs solved in so few time...

I'm relieved to know that, in your estimation, there are not so many false positives.

And to think: Across all six AGEOD AGE system games, using (imperfect) AGElint, by now I have discovered thousands of "almost invisible bugs"!

(And remember: As AGElint performs still more data checks and loses some genericness, as we drill deeper into syntactical and semantic and logical complexities, there are how many -- what, maybe XXX? Y,YYY? -- bugs still to be discovered?)

quote:

ORIGINAL: Chliperic

quote:

ORIGINAL: berto

(And remember: As AGElint performs still more data checks and loses some genericness, as we drill deeper into syntactical and semantic and logical complexities, there are how many -- what, maybe XXX? Y,YYY? -- bugs still to be discovered?)

Certainly some more. How much? I guess from my own experience higher level bugs to be more rare as the scriptreport and player's experience point them out quickly. The worst in AGE script language, due to its verbosty and lack of full coherence, are the small errors unreproted by the official tools having great effects like wrong terrains, etc.

• RUS, Revolution under Siege
  
• ACW, American Civil War
  
• ROP, Rise of Prussia
  
• WIA, Wars in America
  
• NCP, Napoleon's Campaigns
  
• PON, Pride of Nations
  

• ongoing, active modding
  
• ongoing, active, diligent fixing of bugs en masse
  
• ongoing, active, useful, constructive player and modder feedback
  
• player activity
  
• forum activity
  
• closest proximity to bug-free "perfection"
  
• the AGElint developer's areas of personal player interest
  

• In the txt.y parser, reduce genericalness, increase specificity.
  
• Deepen and extend the txt.y parser, refining the syntax checks, but also adding semantic and logical checks.
  
• Integrate SelectFaction & SelectRegion into the semantic and logical checks.
  
• In the txt.y parser, add more CHKINT() checks.
  
• Better pinpoint the exact line number of reported error.
  
• Improve parser 'error' recovery, for detecting all errors etc. in a given data file.
  
• In names, more generally solve the problem of "foreign" (non-English, non-ASCII) characters.
  
• Generally solve the problem of files not ending in EOL (end-of-line, e.g., CR/LF).
  
• Present a pleasing display of blank lines for every possible combination of agelint command arguments.
  
• Better pinpoint the exact DB sources file of reported error.
  

• Add automated setting of agelintroot & gameroot in all scripts, not just the chk*.pl ones (by, for example, universal reference to agelint.conf).
  
• Check for duplication of UIDs/aliases.
  
• Check inter-regional linkages.
  
• Trim, or better categorize, reported "bad" aliases, localizations, graphics files, etc.
  

• Extend the 'make check' to encompass still more regression tests.
  
• Develop a functioning 'make install'.
  
• Add still more examples to the USAGE file.
  
• Host a web services site, where users can upload and check game data files without their having to install and run AGElint locally.
  
• Host on the web the Kwd (AGE keyword usage) database and support programs.
  
• In general, reduce false positives to a bare minimum.
  
• Fix bugs!
  

• In agelint.conf, added acwdir, ncpdir, pondir, ropdir, rusdir, wiadir.
  
• For agelint.conf, priority default location changed from /usr/local/etc to /usr/local/games/etc
  
• Added conf.pl, for agelint.conf processing by Perl scripts.
  
• In agelint.c, cleaned up agelintroot & gameroot code and logic.
  
• Fixed broken 'make check'.
  
• Substituted new, vetted test files in the CHK directory tree (and revised the squelches.chk.pl file).
  
• In agelint, chk*.pl, common.pl, cmd.[ly], etc., cleaned up command-line arguments, and fixed all Usage: statements.
  
• In chkaliases.pl, filtered out some false positives.
  
• In txt.[ly], fixed several bugs & false positives.
  
• Added grprpt.pl & rmgameroot scripts to distribution.
  
• Emptied FIX directory tree of useless junk files.
  
• Added USAGE, CHANGES & TODO files to distribution.
  
• Other minor code & doc fixes/changes.