quote:

ORIGINAL: Chliperic

Another possible false positive:

ChgUnitPoolInfos = $uni_DON_Amt1d;-999;75

The command accepts values from -999 to 999 for variation of force pool

quote:

<variation of Force Pool>

Integer (-999 to 999)

Changes the pool value by this amount

chgunitpoolinfos: _CHGUNITPOOLINFOS eq val sc intpos
                | _CHGUNITPOOLINFOS eq val sc intpos sc intpos
                {
                /*                                                              
                http://www.ageod.net/agewiki/ChgUnitPoolInfos                   
                Syntax:  ChgUnitPoolInfos = <UnitDef>|<variation of Force Pool>|<AI Pool Ratio>       .                                                        
                */
                }
                ;

chgunitpoolinfos: _CHGUNITPOOLINFOS eq val sc int sc pct

                  _CHGUNITPOOLINFOS eq val sc intpos

• The AGE code had been extended to allow different alternative usages (in the ChgUnitPoolInfos example, allowing two arguments instead of three), and the AGEWiki docs had not been updated to reflect the extension.
  
• The AGEWiki doc is just flat out wrong; the actual usages are right.
  
• The AGE code recovers from the syntax errors gracefully, and defaults to some sensible behavior (in the ChgUnitPoolInfos, defaulting say to an assumed value of 100 (percent) for the missing third argument).
  
• The AGE 3.0 game, PON, might be extended to support alternative usages (but the AGEWiki was not yet edited to reflect that).
  
• Most peculiarly, when I saw usage exceptions in RUS -- there were more discovered in RUS than in any other game -- at the time I thought that the agreement with SEPRUS was that Pocus had farmed out the AGE coding to a SEPRUS programmer, thus that the RUS AGE engine code had forked from the mainline, standard AGEOD AGE (2.0) code.
  

quote:

When deciding the txt.y parser rules, I am guided primarily by the AGE Wiki documentation (where it exists, which is not always), and secondarily by actual usage as demonstrated by the game data files. They are not always in agreement! And there is much ambiguity and nuance. Bear that in mind when reviewing/critiquing the txt.y parser specification.

• The AGEWiki pages.
  
• Actual usage (across all games).
  
• Experienced dev/modder feedback (now possible, since I at least have your attention and active cooperation).
  
• Actual experimentation (don't just speculate; "look in the horse's mouth!") (but I really don't have time for it).
  

quote:

ORIGINAL: Chliperic

and 2 others:

ERROR: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Events/RUS All Scenarios.sct, at (or before) line 2287: syntax error: #|# (0x7c), #|#

in event evt_nam_Allied_involment_level:

2284 MaxDate = 1921/12/30
2285
2286 Actions
2287> PopUpText = str_nam_Allied_Involv_01|NULL|2|Allied_Involv_08|Event-img_Renforts_CMN_BlackSeaAllied|NULL
2288 EndEvent

This command accepts | rather than ; as the official tutorial files show it.

quote:


The second false positive is the lack of conditions in the evens in the scripts file (.ini): theses files serving for creating scenarios are made with events command without needing conditions).

Scripts/Script_T1.ini, Fri Oct 1 2010 11:26:12

WARNING: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Scripts/Script_T1.ini, at (or before) line 1130: no Conditions section

1127 Replacement = FIN;$famMilitia;3
1128 NULL = NULL
1129
1130> EndEvent

quote:

At present, AGElint is more than a beginning, but far from an ending. The dream is to code a vast set of utilities and capabilities to check all manner of AGEOD bugs/errors/glitches/anomalies. In agelint itself, beyond the syntax checking already in place, there are the beginnings of semantic and logic checking. Outside of agelint, there are many more QA checks we can apply to the AGE game data files.

#!/usr/bin/perl                                                                 

$DEBUG = 0;

$RUSDIR = "/media/KINGSTON/Games/AGEOD/Revolution under Siege FY/RUS";

open(REGIONS, "$RUSDIR/Aliases/Regions.ini");
while(<REGIONS>) {
    chomp;
    $line = $_;
    next if ($line =~ /^\s*#/);
    next if ($line =~ /^\s*\/\//);
    if ($line =~ /^\s*(\$[^=]+[a-zA-Z0-9])\s*=/) {
        $reglc = lc($1);
        print "#$reglc#\n" if $DEBUG;
        $regions{$reglc}++;
    }
}
close(REGIONS);

open(FIND, "find \"$RUSDIR\" -exec egrep \"SelectRegion\" {} \\; \| awk -F= '{print \$2}' \| sort \| uniq |");
while(<FIND>) {
    chomp;
    print "line #$_#\n" if $DEBUG;
    next unless (/^\s*(\$[-\. a-zA-Z0-9]*[a-zA-Z0-9])/);
    $reg = $1;
    $reglc = lc($reg);
    print "reg  #$reglc#\n" if $DEBUG;
    next if ($reglc =~ /(playboard)/);
    if (! $regions{$reglc}) {
	print "$reg not found\n";
    }
}
close(FIND);

exit 0;

quote:

There's still much more untapped potential, much more to be done...

quote:

[root@telemann agelint]# ./chkSelectRegion.pl 2>&1 | sort | uniq
$Almetevsk not found
$Baltic Channel not found
$Bay of Samsun not found
$Black Sea not found
$Cape Civa not found
$Cape Ince not found
$Fergana not found
$FRA not found
$Gulf of Trapezus not found
$Hoburgen not found
$Huiliaipole not found
$Kalmar Sund not found
$Keuruu not found
$North Baltic Sea not found
$Osel not found
$Ost See not found
$Rustavi not found
$Savo not found
$Shchuche Ozero not found
$South Baltic Sea not found
$Southeastern Black Sea not found
$SouthWestern Black Sea not found
$Swedish Channel not found
$Verkhovie not found

quote:

ORIGINAL: Chliperic

Don't forget FY is for now only the modding of the Grand Campaign. This one doesn't use all the files of RUS;

For example, I've noticed Drang Nach Osten files have a lot of errors. However, as There aren't used in FY, I haven't fixed them. Yet. [:D] So these mispelled aliases in files may result of event files unused in the FY Grand Campaign, which by the contrary, is now 99.99% error free ( I'm yet inspecting 2 reports which may be false positive).

quote:

ORIGINAL: berto

When first coding txt.y, whenever I saw many usage counterexamples (where "many" is loosely defined), I inferred that the counterexamples might be acceptable alternative usages. It could be that

• The AGEWiki doc is just flat out wrong; the actual usages are right.
  

...

In the AGElint README file, I write:

quote:

When deciding the txt.y parser rules, I am guided primarily by the AGE Wiki documentation (where it exists, which is not always), and secondarily by actual usage as demonstrated by the game data files. They are not always in agreement! And there is much ambiguity and nuance. Bear that in mind when reviewing/critiquing the txt.y parser specification.

Going forward, and as I review and refine the txt.y parser, I will have to base "truth" on

• The AGEWiki pages.
  
• Actual usage (across all games).
  
• Experienced dev/modder feedback (now possible, since I at least have your attention and active cooperation).
  
• Actual experimentation (don't just speculate; "look in the horse's mouth!") (but I really don't have time for it).
  

in that order of authority.

chgpopeducation: _CHGPOPEDUCATION eq intpos
                {
                /*                                                              
                http://www.ageod.net/agewiki/ChgPopEducation                    
                Syntax:  ChgPopEducation = Value  Or  ChgPopEducationEx = Servile|Peasant|Worker|Middle|Upper|Aristocrat                                       
                */
                }
                ;

chgpopeducationex: _CHGPOPEDUCATIONEX eq int sc int sc int sc int sc int sc int all
                { CHKINT( $3, -999, -999, 999, 999);
                  CHKINT( $5, -999, -999, 999, 999);
                  CHKINT( $7, -999, -999, 999, 999);
                  CHKINT( $9, -999, -999, 999, 999);
                  CHKINT($11, -999, -999, 999, 999);
                  CHKINT($13, -999, -999, 999, 999);
                /*                                                              
                http://www.ageod.net/agewiki/ChgPopEducation                    
                Syntax:  ChgPopEducation = Value  Or  ChgPopEducationEx = Servile|Peasant|Worker|Middle|Upper|Aristocrat                                       
                                                                                
                documented | but ; in actual usage                              
                the appended 'all' is undocumented but conforms to actual usage  
                */
                }
                ;

all:              /* empty, no problem */
                | sc _ALL
                ;

chgunitpoolinfos: _CHGUNITPOOLINFOS eq unidefval sc int {
                    txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, apparent omission of <AI Pool Ratio> as third argument");
                  }
                | _CHGUNITPOOLINFOS eq unidefval sc int sc pct
                {
                /*
                http://www.ageod.net/agewiki/ChgUnitPoolInfos
                Syntax:  ChgUnitPoolInfos = <UnitDef>|<variation of Force Pool>|<AI Pool Ratio>

                contrary to the docs, uses ; instead of |
                */
                }
                ;

quote:

ORIGINAL: Chliperic

An example:

[...]
Line 162818: => ChgUnitPoolInfos, need to have exactly 3 parameters: Alias of UnitDef, variation of Force Pool, AI Pool Ratios
[...]

quote:

http://www.ageod.net/agewiki/ChgUnitPoolInfos

This wiki page has been updated today to point out the third parameter was optional. That's wrong, obviously, as my test event is described wrong by the scriptreport generated by the AGE engine. Or the AGE engine is reporting a wrong alarm, or the command needs the 3 parameters.The first hypothesis is possibly the right one, as the report doesn't mention any change for the AI setting for this unit...Rather strange, no? I will however let the official team to work on this point, as myself I just use always the 3 parameters, even for the "default value": 100. AT least I'm sure it will work[8D].

quote:

That's my way: before saying something, I TEST first.

quote:

BTW, Berto, there is one better method for having access to the scripting language than the wiki, which will never replace a good old modding manual. Much less fancy but so much more convenient. I'm going to explain you in PM.[;)]

quote:

I'd like to do that, too. But it's so tedious. Setting up and testing an answer to every little uncertainty and question would take forever (especially doing it the .xls DB -> CSV Splitter -> ... way). Life is too short! And AGElint would still be stuck at a rudimentary, version 0.10 level.

evalisatpeacewith: _EVALISATPEACEWITH eq facnam
                | _EVALISATPEACEWITH eq facnam sc _NOT {
                    txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, undocumented usage of NOT parameter");
                  }
                {
                /*
                http://www.ageod.net/agewiki/EvalIsAtPeaceWith
                Syntax:  EvalIsAtPeaceWith = <Faction tag>
		*/
                }
                ;

setadvrevolt:     _SETADVREVOLT eq facnam sc intpos sc intpos sc intpos sc pct sc pct sc unidefval sc unidefval
                | _SETADVREVOLT eq intpos sc intpos sc intpos sc pct sc pct sc unidefval sc unidefval
                | _SETADVREVOLT eq facnam vb intpos vb intpos vb intpos vb pct vb pct vb unidefval vb unidefval {
                    txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, undocumented usage of | as field separator");
                  }
                | _SETADVREVOLT eq intpos vb intpos vb intpos vb pct vb pct vb unidefval vb unidefval {
                    txterrmsg(_WARNING, TRUE, linenorhs, "suspicious, undocumented usage of | as field separator");
                  }
                {
                /*
                http://www.ageod.net/agewiki/SetAdvRevolt
                Syntax:  SetAdvRevolt = [FacTag]; RevoltStrength; RegenAmount; MaxRegenHits; LosePerc; WinPerc; CityUp; CountryUp
                */
                }
                ;

quote:

ORIGINAL: berto


I expect to release AGElint 1.1 -- with improved AACW support -- no later than mid week.

quote:

ORIGINAL: Chliperic

another warning which is maybe a false positive:


WARNING: in /cygdrive/c/AGEod's American Civil War/AGEod's American Civil War/ACW/Events/USA Events.sct, at (or near) line 2429: suspicious, undocumented usage of a number (126) instead of sound ID

2426
2427 SelectFaction = $USA
2428 SelectRegion = $Prince George's, MD
2429> StartEvent = evt_nam_USA_PrisonersPolicy|1|2|evt_txt_USA_PrisonersPolicy|Event-img_USA_PrisonersPolicy|$Prince George's, MD|126
2430
2431 Conditions
2432 MinDate = 1862/01/01

Syntax: StartEvent = Name|Occurences|DisplayType|EventText|EventPic|Region|Sound

quote:

ORIGINAL: berto

quote:

ORIGINAL: Chliperic

another warning which is maybe a false positive:


WARNING: in /cygdrive/c/AGEod's American Civil War/AGEod's American Civil War/ACW/Events/USA Events.sct, at (or near) line 2429: suspicious, undocumented usage of a number (126) instead of sound ID

2426
2427 SelectFaction = $USA
2428 SelectRegion = $Prince George's, MD
2429> StartEvent = evt_nam_USA_PrisonersPolicy|1|2|evt_txt_USA_PrisonersPolicy|Event-img_USA_PrisonersPolicy|$Prince George's, MD|126
2430
2431 Conditions
2432 MinDate = 1862/01/01

Syntax: StartEvent = Name|Occurences|DisplayType|EventText|EventPic|Region|Sound

The problem might relate to 'Event-img_USA_PrisonersPolicy' lacking, for example, a .png file extension; or possibly the ' and , in the '$Prince George's, MD' region alias.

But be aware that I have made significant and wide-ranging changes in the txt.l lexer and also txt.y parser since the AGElint 1.00 version you now have in your possession.

In any case, I'll check.