berto -> RE: The Countdown Thread -- Crazy is as crazy does (8/31/2015 4:32:57 PM)
|
A blast from the past: Coder Diary #17 -- Past, Present & Future ... And continuing on to the present. Posted recently in the Dev Forum (and airing a bit of our dirty linen): quote:
ORIGINAL: berto For the RC 20150830 FULL GAME install... First CSlint results, these from cschkinstall.pl. cschkinstall.pl compares the current install (20150830) to the previous one (in this case Jason's 20150828 install). cschkinstall.pl reports no ERRORs! Robert@roberto ~/cslint $ egrep -i "error" cschkinstall.20150830.out [nil] This is very good. Some WARNINGs, some of them false positives or unimportant, but others of special note highlighted: Robert@roberto ~/cslint $ egrep -i "warning" cschkinstall.20150830.out | egrep -v "(size|cksum|mtime) difference|bad extension|\.log not found|saves/.*not found|pictures.*not found" WARNING: file graphics/op082096.bit not found in ref DB WARNING: file graphics/op082099.bit not found in ref DB WARNING: file graphics/op082102.bit not found in ref DB WARNING: file graphics/op085020.bit not found in ref DB WARNING: file graphics/op290018.bit not found in ref DB WARNING: file graphics/sp085018.bit not found in ref DB WARNING: file graphics/sp085019.bit not found in ref DB WARNING: file graphics/up082096.bmp not found in ref DB WARNING: file graphics/up082099.bmp not found in ref DB WARNING: file graphics/up082102.bmp not found in ref DB WARNING: file graphics/up085018.bmp not found in ref DB WARNING: file graphics/up085019.bmp not found in ref DB WARNING: file graphics/up085020.bmp not found in ref DB WARNING: file graphics/up290018.bmp not found in ref DB WARNING: file manual/sumatrapdf-settings.txt not found in ref DB WARNING: file manual/sumatrapdfcache/0beeca32fb5f8048a90a21fa7648a2fd.png not found in ref DB WARNING: file manual/sumatrapdfcache/1456cff335a8fa3eb3b62455fe7e2d6f.png not found in ref DB WARNING: ref DB file data/unittext.txt not found WARNING: ref DB file encrypt.exe not found WARNING: ref DB file manual/csme_manual_100_draft_letter_noimages.docx not found WARNING: ref DB file manual/csme_manual_100_draft_letter_noimages.zip not found WARNING: file graphics/sides3d.bmp newer than graphics/sidesnight3d.bmp WARNING: file oobs/leader8.oob has bad name WARNING: file oobs/leader9.oob has bad name "not found in ref DB" indicates a new addition. "not found" indicates a removal. Please review the above WARNINGs to see if anything is of concern. Be sure to verify the graphics additions in the above list. We accept the need for having both Leader8.oob & Leader08.oob, and Leader9.oob & Leader09.oob. Searching through the code: Robert@roberto /cygdrive/c/Documents and Settings/Robert/My Documents/Games/Matrix Games/CS/devel/Campaign Series $ find . -type f -exec egrep -il "leader.*oob" {} \; | ./cpph ./edorg/edorg.cpp ./frontend/Fetch.cpp That's two different places in the code where the Leader OOB files are referenced. Although I might inspect the code, I can't confidently predict that it should be Leader8.oob instead of Leader08.oob, or vice versa (and similarly for nation 9's Leader OOB file). Much less do I/we have the time to test it thoroughly right now. So, regrettably, we will have to accept the file duplication. However, please note: Robert@roberto /cygdrive/f/Games/Matrix Games/Middle East $ cksum middle_east/OOBs/Leader[89].oob middle_east/OOBs/Leader0[89].oob | sort -n 3119115043 515 middle_east/OOBs/Leader08.oob 3292444730 362 middle_east/OOBs/Leader09.oob 3292444730 362 middle_east/OOBs/Leader8.oob 3292444730 362 middle_east/OOBs/Leader9.oob The last three files are identical in checksum, and size (bytes). But the nation 8 Leader OOB files don't match! They should. Please review. The data/unittext.txt removal is correct. In fact, the game code is looking for unittext.txt in the texts folder: gfnam = GameFile (XTexts, "unittext.txt"); I confirmed that unit texts are displaying in the F2 Unit Handbook. So no problem with unittext.txt. encrypt.exe has been removed. Good! The manual removals are appropriate. The manual/sumatrapdfcache/*.png files -- maybe best to leave well enough alone. @Petri: Note the warning about "graphics/sides3d.bmp newer than graphics/sidesnight3d.bmp" -- should we be concerned? More to follow... quote:
ORIGINAL: berto csgfxchk.pl results: Robert@roberto ~/cslint $ ./csgfxchk.pl -n +w +e -g me | egrep -v "no.*picture file" ERROR: for unit BMP file Up0288804.bmp, no corresponding BIT file (P0288804: <UNKNOWN>) ERROR: for unit BMP file Up248005.bmp, no corresponding BIT file (P248005: <UNKNOWN>) WARNING: for unit BIT file Op141010.bit, no corresponding BMP file (P141010: <UNKNOWN>) WARNING: for unit BIT file Op220021.bit, no corresponding BMP file (P220021: <UNKNOWN>) WARNING: for unit BIT file Op281003.bit, no corresponding BMP file (P281003: <UNKNOWN>) WARNING: for unit BIT file Op281011.bit, no corresponding BMP file (P281011: <UNKNOWN>) WARNING: for unit BIT file Op288804.bit, no corresponding BMP file (P288804: <UNKNOWN>) These are, I think, the same results from two days ago. There might be some false positives in that. This was maybe already confirmed. If so, just disregard. And other posts like the above ... until: quote:
ORIGINAL: berto csutxchk.pl looks good: Robert@roberto ~/cslint $ ./csutxchk.pl -n +w +e -g me [nil] Yay! That concludes my CSlint checks for now. I had really wanted to supplement my routine CSlint checks with some additional ad hoc, command line data vetting. Maybe I'll get to some of that later this week. (Idle thought: Can you imagine how useful, essential even, (a by then beefed up) CSlint etc. will be when we need to vet the JTCS 3.0 data -- a data set at least 10X larger than the ME one? [X(]) So we have a few QA tricks up our sleeves. But despite that, will Middle East ship entirely, 100% bug free? Hardly! But it won't be for lack of trying!
|
|
|
|